Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update go deps in examples/go.mod #411

Closed
wants to merge 1 commit into from

Conversation

dmitris
Copy link
Contributor

@dmitris dmitris commented Feb 18, 2025

Summary

Update Go dependencies to be able to run go install -v github.com/sigstore/sigstore-go/examples/oci-image-verification in the examples/ directory. Currently when trying to run that command, I'm getting an error:

$ GOBIN=/tmp/bin go install -v github.com/sigstore/sigstore-go/examples/oci-image-verification
no required module provides package github.com/sigstore/sigstore-go/examples/oci-image-verification; to add it:
	go get github.com/sigstore/sigstore-go/examples/oci-image-verification

This may partially overlap with the open #410 - if you merge that one first, I'll rebase on trunk.

Release Note

NONE

Documentation

n/a

@dmitris dmitris requested a review from a team as a code owner February 18, 2025 15:16
Signed-off-by: Dmitry Savintsev <[email protected]>
@codysoyland
Copy link
Member

Hi @dmitris, thanks for the PR. We intentionally keep the oci-image-verification module separate from the main module to reduce dependencies in the main module. Can you use make build-examples or go install -C ./examples/oci-image-verification . instead?

@dmitris
Copy link
Contributor Author

dmitris commented Feb 18, 2025

Can you use make build-examples or go install -C ./examples/oci-image-verification . instead?

Sure - would be good to highlight that in the README for examples/ - opened #412 for that.

@dmitris dmitris closed this Feb 18, 2025
@dmitris dmitris deleted the examples-deps branch February 18, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants