Skip to content

Conversation

@eserilev
Copy link
Member

@eserilev eserilev commented Nov 2, 2025

Issue Addressed

#8135

mainnet config PR: eth-clients/mainnet#11

@eserilev eserilev added ready-for-review The code is ready for review fulu Required for the upcoming Fulu hard fork labels Nov 2, 2025
@mergify
Copy link

mergify bot commented Nov 2, 2025

Some required checks have failed. Could you please take a look @eserilev? 🙏

@mergify mergify bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Nov 2, 2025
@michaelsproul michaelsproul added the v8.0.0 Q4 2025 Fusaka Mainnet Release label Nov 2, 2025
@michaelsproul
Copy link
Member

I've fixed the tests by resolving a FIXME that was sitting there in the execution_block_generator:

It might be cleaner long term to plumb in a slot clock, but this method suffices for now and is relatively simple.

Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and have confirmed correspondence with upstream.

Copy link
Member

@chong-he chong-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked the values and they match the upstream too.

@mergify mergify bot added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Nov 3, 2025
@chong-he
Copy link
Member

chong-he commented Nov 3, 2025

Updated the comment to be in sync with: https://github.com/eth-clients/mainnet/pull/11/files#diff-1804ca2400832db3683d071e0734283eadeda1ff359c2c89b88abad1a78b0ef4

Mostly comment changes, and some rearrange of the parameters

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Nov 3, 2025
@mergify mergify bot added the queued label Nov 3, 2025
mergify bot added a commit that referenced this pull request Nov 3, 2025
mergify bot added a commit that referenced this pull request Nov 3, 2025
mergify bot added a commit that referenced this pull request Nov 3, 2025
mergify bot added a commit that referenced this pull request Nov 3, 2025
@jimmygchen jimmygchen mentioned this pull request Nov 3, 2025
1 task
jimmygchen added a commit to jimmygchen/lighthouse that referenced this pull request Nov 3, 2025
Squashed commit of the following:

commit bc301da
Author: Tan Chee Keong <[email protected]>
Date:   Mon Nov 3 12:06:29 2025 +0800

    update comment in config

commit dc6576e
Author: Michael Sproul <[email protected]>
Date:   Mon Nov 3 14:57:31 2025 +1100

    Address review comments

commit 841a42f
Author: Michael Sproul <[email protected]>
Date:   Mon Nov 3 12:11:59 2025 +1100

    Appease Clippy

commit 17d02b8
Author: Michael Sproul <[email protected]>
Date:   Mon Nov 3 11:37:46 2025 +1100

    Fix tests by using correct max_blobs_per_block for epoch

commit b941dec
Author: Eitan Seri-Levi <[email protected]>
Date:   Sun Nov 2 13:41:31 2025 -0800

    Fmt

commit e43209c
Author: Eitan Seri-Levi <[email protected]>
Date:   Sun Nov 2 13:22:48 2025 -0800

    Fix test

commit 991804e
Author: Eitan Seri-Levi <[email protected]>
Date:   Sun Nov 2 10:36:22 2025 -0800

    Add mainnet configs
@mergify mergify bot merged commit 25832e5 into sigp:release-v8.0 Nov 3, 2025
36 of 37 checks passed
@mergify mergify bot removed the queued label Nov 3, 2025
@jimmygchen jimmygchen mentioned this pull request Nov 3, 2025
mergify bot pushed a commit that referenced this pull request Nov 4, 2025
N/A

Includes the following unmerged PRs:
- #8344
- #8335
- #8339

This PR should be merged after all above PRs are merged.


  


Co-Authored-By: Jimmy Chen <[email protected]>

Co-Authored-By: Jimmy Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fulu Required for the upcoming Fulu hard fork ready-for-merge This PR is ready to merge. v8.0.0 Q4 2025 Fusaka Mainnet Release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants