-
Notifications
You must be signed in to change notification settings - Fork 931
Add mainnet configs #8344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mainnet configs #8344
Conversation
|
Some required checks have failed. Could you please take a look @eserilev? 🙏 |
|
I've fixed the tests by resolving a It might be cleaner long term to plumb in a slot clock, but this method suffices for now and is relatively simple. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and have confirmed correspondence with upstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have checked the values and they match the upstream too.
common/eth2_network_config/built_in_network_configs/mainnet/config.yaml
Outdated
Show resolved
Hide resolved
|
Updated the comment to be in sync with: https://github.com/eth-clients/mainnet/pull/11/files#diff-1804ca2400832db3683d071e0734283eadeda1ff359c2c89b88abad1a78b0ef4 Mostly comment changes, and some rearrange of the parameters |
Squashed commit of the following: commit bc301da Author: Tan Chee Keong <[email protected]> Date: Mon Nov 3 12:06:29 2025 +0800 update comment in config commit dc6576e Author: Michael Sproul <[email protected]> Date: Mon Nov 3 14:57:31 2025 +1100 Address review comments commit 841a42f Author: Michael Sproul <[email protected]> Date: Mon Nov 3 12:11:59 2025 +1100 Appease Clippy commit 17d02b8 Author: Michael Sproul <[email protected]> Date: Mon Nov 3 11:37:46 2025 +1100 Fix tests by using correct max_blobs_per_block for epoch commit b941dec Author: Eitan Seri-Levi <[email protected]> Date: Sun Nov 2 13:41:31 2025 -0800 Fmt commit e43209c Author: Eitan Seri-Levi <[email protected]> Date: Sun Nov 2 13:22:48 2025 -0800 Fix test commit 991804e Author: Eitan Seri-Levi <[email protected]> Date: Sun Nov 2 10:36:22 2025 -0800 Add mainnet configs
N/A Includes the following unmerged PRs: - #8344 - #8335 - #8339 This PR should be merged after all above PRs are merged. Co-Authored-By: Jimmy Chen <[email protected]> Co-Authored-By: Jimmy Chen <[email protected]>
Issue Addressed
#8135
mainnet config PR: eth-clients/mainnet#11