Gloas modify get_pending_balance_to_withdraw #8302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shane-moore
changed the title
shane-moore
changed the title
ethDreamer
merged commit 150b117
into
sigp:gloas-envelope-processing
20 of 25 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes per spec
get_pending_balance_to_withdrawHow this works
There are a couple places in the codebase where we want to verify that a validator has no pending balances to withdraw before allowing them to initiate an exit or consolidation. Pre-gloas, we were calling
get_pending_balance_to_withdrawto check whether theirBeaconState.pending_partial_withdrawalswas empty and if so, let them proceed. Since gloas introducesBeaconState.builder_pending_paymentsandBeaconState.builder_pending_withdrawals, we now have to account for these pending validator balances as well before letting them proceed with an exit or consolidation.@ethDreamer
@eserilev