Match BlockError into penalty in block gossip #8301
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
In process_gossip_unverified block we match the verification error and we should always:
However, for some variants we don't do that. This PR refactors the match to always:
If others thumbs up this style I can extend to the other gossip messages. This style makes gossip handling more consistent and less chance of forgetting to propagate results or penalize peers.
For some variants like
Slashablewe penalize the peer in our internal scoring but we don't penalize in the gossip layer. This is odd, anyone knows why?