Allow get_beacon_proposer_index at next epoch #8235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
blocked
consensus
2 tasks
dapplion
reviewed
Oct 27, 2025
| let epoch = slot.epoch(E::slots_per_epoch()); | ||
| // TODO(EIP-7917): Explore allowing this function to be called with a slot one epoch in the future. | ||
| if epoch != self.current_epoch() { | ||
| if epoch != self.current_epoch() && epoch != self.next_epoch()? { |
There was a problem hiding this comment.
Would be more intuitive to move this if check after the "Post-Fulu" comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Continued cleanup of proposer index logic, this PR allows
get_beacon_proposer_indexto be called at the next epoch (post-Fulu), bringing it in line withget_beacon_proposer_indicesafter the changes in:This is a safe change for Fulu due to the newly introduced lookahead.
Additional Info
This change is non-essential for correctness, as
get_beacon_proposer_indexis currently only called for the current epoch (state.slot()orblock.slot()after state advance), and in tests.