-
Notifications
You must be signed in to change notification settings - Fork 931
Prepare sensitive_url for crates.io
#8223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Some required checks have failed. Could you please take a look @macladson? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Keen!
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You can check the last failing draft PR here: #8359. You may have to fix your CI before adding the pull request to the queue again. |
2b977ff to
20b74c6
Compare
|
@mergify requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
Issue Addressed
Another good candidate for publishing separately from Lighthouse is
sensitive_urlas it's a general utility crate and not related to Ethereum. This PR prepares it to be spun out into its own crate.Proposed Changes
I've made the
fullfield onSensitiveUrlprivate and instead provided an explicit getter called.expose_full(). It's a bit ugly for the diff but I prefer the explicit nature of the getter.I've also added some extra tests and doc strings along with feature gating
SerializeandDeserializeimplementations behind theserdefeature.Additional Info
I also removed
AsRef<str>as this was previously used quite awkwardly and instead I've implemented a.redacted()getter which I think is cleaner.