Repository navigation
Deduplicate slasher ingress for identical indexed attestations - #10107
Open
NikhilSharmaWe wants to merge 2 commits into
Open
NikhilSharmaWe wants to merge 2 commits into
NikhilSharmaWe wants to merge 2 commits into
Conversation
Signed-off-by: Nikhil Sharma <nikhilsharma230303@gmail.com>
michaelsproul
added
optimization
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mutating only
SingleAttestation.committee_indexproduces a new gossip message ID but the same indexed attestation. With--slasher,PriorAttestationKnownreplays still did an individual BLS verify and were appended to an unbounded ingress queue.Deduplicate the slasher ingress queue on
(validator_index, attestation_data_hash), and skip verify/accept inprocess_slash_infowhen that attestation is already staged. ConflictingAttestationDatafrom the same validator is still accepted.Fixes #10086
Test plan
cargo check -p slasher -p beacon_chain --features "slasher/lmdb"cargo nextest run -p slasher --features "lmdb"cargo nextest run -p beacon_chain --release --features "slasher/lmdb" unaggregated_attestation_committee_index_replay unaggregated_attestation_bogus_attester_index_not_sent_to_slasher