Gloas spec beta 0 - #10014
Merged
Merged
Conversation
michaelsproul
self-requested a review
September 8, 2026 23:44
eserilev
added
work-in-progress
eserilev
force-pushed
the
gloas-spec-beta-0
branch
from
September 9, 2026 01:28
a365f02 to
f723bf4
Compare
Member
|
idk what the test failures are about, can you take a look @eserilev ? |
|
Queued — the merge queue status continues in this comment ↓. |
eserilev
force-pushed
the
gloas-spec-beta-0
branch
3 times, most recently
from
September 9, 2026 03:13
1b88423 to
96c34b6
Compare
eserilev
force-pushed
the
gloas-spec-beta-0
branch
from
September 9, 2026 03:17
96c34b6 to
41b545d
Compare
eserilev
added
ready-for-review
Comment on lines
+2837
to
+2851
| let validator_index = exit.message.validator_index; | ||
| if exit.message.epoch > wall_clock_epoch { | ||
| return Err(ExitValidationError::invalid(ExitInvalid::FutureEpoch { | ||
| state: wall_clock_epoch, | ||
| exit: exit.message.epoch, | ||
| }) | ||
| .into()); | ||
| } | ||
| if let Some(validator) = head_state.validators().get(validator_index as usize) | ||
| && validator.exit_epoch != self.spec.far_future_epoch | ||
| { | ||
| return Err( | ||
| ExitValidationError::invalid(ExitInvalid::AlreadyExited(validator_index)).into(), | ||
| ); | ||
| } |
Member
There was a problem hiding this comment.
Why is this added/duplicated here?
Member
There was a problem hiding this comment.
Ah, I guess it's for the condition ordering. That's OK I guess.
michaelsproul
added
ready-for-merge
Merge Queue Status
This pull request spent 30 minutes 10 seconds in the queue, including 26 minutes 47 seconds running CI. Required conditions to merge
|
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Each commit has a link to the relevant consensus spec PR