Skip to content

Release v3.5.2 #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JiSoft merged 1 commit into from
Feb 25, 2026
Merged

Release v3.5.2 #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# signNow API PHP SDK
## v3.5.1
## v3.5.2

[![PHP Version](https://img.shields.io/badge/supported->=8.2-blue?logo=php)](https://php.net/)

Expand All @@ -11,7 +11,7 @@
### Installation
Get SDK code via composer
```bash
composer require signnow/api-php-sdk:v3.5.1
composer require signnow/api-php-sdk:v3.5.2
```
or via git
```bash
Expand Down
1 change: 1 addition & 0 deletions src/SignNow/Core/Config/ConfigDefaults.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
final readonly class ConfigDefaults
{
public const SIGNNOW_API_HOST = 'https://api.signnow.com';
public const SIGNNOW_API_TIMEOUT = 30;
public const USERNAME = '';
public const PASSWORD = '';
public const BASIC_TOKEN = '';
Expand Down
1 change: 1 addition & 0 deletions src/SignNow/Core/Config/ConfigLoader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ private function loadEnvironmentVariablesOrDefaults(): array
'signnow_api_basic_token' => $this->getEnvOrDefault('SIGNNOW_API_BASIC_TOKEN', ConfigDefaults::BASIC_TOKEN),
'signnow_api_host' => $this->getEnvOrDefault('SIGNNOW_API_HOST', ConfigDefaults::SIGNNOW_API_HOST),
'signnow_downloads_dir' => $this->getEnvOrDefault('SIGNNOW_DOWNLOADS_DIR', ConfigDefaults::DOWNLOADS_DIR),
'signnow_api_timeout' => getenv('SIGNNOW_API_TIMEOUT') ?? ConfigDefaults::SIGNNOW_API_TIMEOUT,
];
}

Expand Down
9 changes: 6 additions & 3 deletions src/SignNow/Core/Config/ConfigRepository.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,10 @@

class ConfigRepository
{
private const CLIENT_NAME = 'SignNowApiClient/v3.5.1 (PHP)';
private const TIMEOUT = 10;
private const CLIENT_NAME = 'SignNowApiClient/v3.5.2 (PHP)';
private const DEFAULT_TIMEOUT = 30;
private const HOST = 'signnow_api_host';
private const TIMEOUT = 'signnow_api_timeout';
private const USERNAME = 'signnow_api_username';
private const PASSWORD = 'signnow_api_password';
private const BASIC_TOKEN = 'signnow_api_basic_token';
Expand Down Expand Up @@ -57,7 +58,9 @@ public function host(): string

public function timeout(): int
{
return self::TIMEOUT;
return !empty($this->config[self::TIMEOUT])
? (int) $this->config[self::TIMEOUT]
: self::DEFAULT_TIMEOUT;
}

public function projectDirectory(): string
Expand Down