[pull] master from openSUSE:master #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
The job unit-ro is from a different file, so "needs" can not find it. Remove it as there is no dependency. An alternative would be to merge both files into one. It might save work on some broken PRs.
Fix these by adding a default empty assignment: osc/commandline.py:3382:62: E0606: Possibly using variable 'filter_pattern' before assignment (possibly-used-before-assignment) osc/commandline.py:6692:18: E0606: Possibly using variable 'msg' before assignment (possibly-used-before-assignment) osc/core.py:2051:23: E0606: Possibly using variable 'file_changed' before assignment (possibly-used-before-assignment) These could probably be fixed by making the code easier to follow. By silencing them for now and making the CI pass, it is easier to not regress. osc/commandline.py:3269:55: E0601: Using variable 'incident' before assignment (used-before-assignment) osc/commandline.py:3276:55: E0601: Using variable 'priority' before assignment (used-before-assignment) This is pylint not understanding that the try is for catching this case and only importing when available: osc/conf.py:77:4: E0401: Unable to import 'keyring' (import-error)
Fix or silence remaining pylint errors
Support 'enabled' field in tokens
Fix build-install CI job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )