feat(sigsci_corp_user): Add corp user resource #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resource allows the provider to create, read, and delete a SigSci Corp User. It also allows managing membership to sites and level of access on initial creation. The upstream library (sigsci-go) does not seem to support membership updates on a user. I would love to get some feedback on how we should handle membership either here or in the upstream module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resource allows the provider to create, read, and delete a SigSci Corp User. It also allows managing membership to sites and level of access on initial creation. The upstream library (sigsci-go) does not seem to support membership updates on a user. I would love to get some feedback on how we should handle membership either here or in the upstream module.
This requires the changes made in signalsciences/go-sigsci#75 to work. I tested this locally but do not have an extra Signal Science account where I would feel comfortable running the full test suite.