Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

description is optional in corp signal tags #198

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

cduelo
Copy link
Contributor

@cduelo cduelo commented Aug 31, 2023

No description provided.

@daniel-corbett daniel-corbett self-requested a review April 17, 2024 22:17
@daniel-corbett
Copy link
Collaborator

Hi @carlosduelo - sorry for the delay here. I have made a few updates to your PR. Notably, switching from Required to Optional and also running make docs. Thanks for your contribution!

@daniel-corbett daniel-corbett merged commit c2d19c3 into signalsciences:main Apr 17, 2024
2 checks passed
@daniel-corbett
Copy link
Collaborator

Hi @carlosduelo - thanks for your contribution! This is now available in version 3.0.1. If you have not upgraded to 3.x yet please keep in mind it is a breaking change. We have a detailed guide here - please read it thoroughly:

https://registry.terraform.io/providers/signalsciences/sigsci/latest/docs/guides/3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants