SignalScience: added missing ja3Fingerprint condition #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able on the web interface
|
Hi @zsoltj - thanks for the PR. At this time this feature is still a beta feature and not available to all customers. We'll need to wait until it is generally available before accepting this PR. |
|
Hi @daniel-corbett - is it possible to be added now? Thank you! |
|
@zsoltj - can you please run |
|
@zsoltj - ping here. I can also re-submit this PR but wanted to give you the opportunity first. |
daniel-corbett
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in missing condition.field value for JA3Fingerprint that is now available on the web interface