-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding hcl tags so a terraform config can be generated #10
Open
janitha09
wants to merge
18
commits into
signalsciences:main
Choose a base branch
from
janitha09:master
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janitha09
commented
Oct 13, 2020
•
edited
Loading
edited
Added functions to create and delete sites not committing the test files yet
Adds create and delete methods for Site Rules
Add GetSiteByRuleId to the api add api_test
Readactions returns all redactions I assume that the list is ordered and the last one is taken to be the one that was created. A test checks for this Test for alerts and lists also added. gitignore adds settings and launch file
api corp rules and lists. using the same List structure for corps and site. Did not combine the corp rules and site rules structures sitenames and corpscope are additions to it. To some extent influenced by the existing code that doesn't combine and update and create nor the response.
…ng and method naming convention adds site and corp signals
This allows you to generate terraform HCL using a snippet like this ```go func (l localCreateSiteRuleBody) marshalText(localName, site, dependson string) string { str := fmt.Sprintf(`resource "sigsci_site_rule" "%s" { %s site_short_name="%s" `, localName, dependson, site) f := hclwrite.NewEmptyFile() gohcl.EncodeIntoBody(&l, f.Body()) str += string(f.Bytes()) // str += marshalStructText(l) str += "}\n" return str } ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.