Open
Conversation
JWinermaSplunk
force-pushed
the
retrievals
branch
from
5dd4952 to
b0b94d6
Compare
shuningc
reviewed
Dec 9, 2025
util/opentelemetry-util-genai/src/opentelemetry/util/genai/attributes.py
Show resolved
Hide resolved
Contributor
|
Overall looks good to me. |
shuwpan
reviewed
Dec 18, 2025
| # Recommended attributes | ||
| retriever_type: Optional[str] = field( | ||
| default=None, | ||
| metadata={"semconv": "gen_ai.retrieval.type"}, |
Contributor
There was a problem hiding this comment.
nit: Shall we use those constants when available instead of hardcoding ?
Contributor
Author
There was a problem hiding this comment.
Yes, think I didn't want to add attributes directly to GenAIAttributes before they were officially in semconv, so it should be revisited.
pradystar
reviewed
Feb 2, 2026
| ) | ||
|
|
||
| # Opt-in attribute | ||
| results: list[dict[str, Any]] = field( |
Contributor
There was a problem hiding this comment.
shouldn't this be structured data like input and output messages instead of list?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add retrieval type to genai utils