Fix #7456: background image dissapears after undo first action #7526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial snapshot was takken before background image was set to canvas. When undoing this caused canvas to restore to a state without background. Now wait for background image to exist in fabric canvas and take initial snaphot in separate effect.
HreshchyshynT
force-pushed
the
fix-issue-7456
branch
from
f1c4cc1 to
63bd1d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor checklist:
Contributor checklist:
mainbranchpnpm run readyrun passes successfully (more about tests here)Description
This PR fixes #7456
Initial problem: background image dissapeared after undo of a first drawing, adding text or sticker.
Reason: it happened because MediaEditor did initial canvas snapshot before background image was set.
Fix: take snapshot after canvas's background image is set.
Testing: I've added ts/test-mock/messaging/media_editor_test.ts. 'can undo after drawing a line' test fails with current implementation and succeed after fix. It basically reproduces user behavior: run app, open chat, add attachment, open editor, draw a line and tap undo.
OS: macOS Sequoia 15.6.1
I didn't work with react, electron, or js/ts projects before, so my solution and tests may not align with best practices or some code styles. I'm happy to adjust anything based on your comments - I just encounter this bug often and want it to be fixed.