Copy-Paste Formatting Inheritance #7512
Open
+225
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Check if we're selecting all content | ||
| const totalLength = this.quill.getLength(); | ||
| const isSelectingAll = selection.length >= totalLength - 1; |
There was a problem hiding this comment.
Ah, I see that quill.getLength() always includes an additional \n character, nice find!
ts/quill/signal-clipboard/index.ts
Outdated
| if (selection.length === 0) { | ||
| formats = this.quill.getFormat(selection.index); | ||
| } else if (isSelectingAll || !signal) { | ||
| // No formatting for select-all or external plain text |
There was a problem hiding this comment.
Not including formats for external text is a departure from current behavior, and I think means:
- select formatted section in the compose box (but not the whole selection)
- paste behavior of unformatted text now varies:
- paste with unformatted signal text -> inherits format
- paste with unformatted external text -> stays unformatted
I'm not sure we want that difference in behavior. Let's preserve the original behavior here, unless there's a reason for the change I'm not thinking of.
| import { SignalClipboard } from '../../quill/signal-clipboard/index.js'; | ||
| import { QuillFormattingStyle } from '../../quill/formatting/menu.js'; | ||
|
|
||
| class MockQuill { |
There was a problem hiding this comment.
this is very cool and will be useful!
|
Thank you for the feedback! I've updated index.dom.ts to not remove formatting when pasting external tests, as well as changed file names as needed. |
trevor-signal
approved these changes
Oct 31, 2025
|
Thanks @brianHarder! This has been merged internally and will be included in the next beta release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist:
mainbranchpnpm run readyrun passes successfully (more about tests here)Description
This PR ensures that existing formatting is not inherited when unformatted text is pasted in to replace the existing text. To implement this change, index.ts in the ts/quill/signal-clipboard directory has been modified to add a check for select all. If a paste event happens when all text is selected, no formatting is applied. This PR partially addresses GH issue #6793.
I manually tested this PR by performing paste events in the mock environment. I tested that selecting all and pasting cleared the formatting and that pasting into a partial section kept the formatting. I also added a test file to simulate the paste all event in two scenarios - strikethrough and text with multiple formats applied - and check that no formatting is applied. I did all my testing on my laptop, which runs macOS 10.15.7.
Screen.Recording.2025-10-01.at.3.33.03.PM.mov