Skip to content

Fix issue #7279: set selected emoji color to be transparant; set sele… #7299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix issue #7279: set selected emoji color to be transparant; set sele… #7299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions stylesheets/components/fun/FunEmoji.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,14 @@ $inline-emoji-container-name: inline-emoji;
line-height: 64px;
user-select: text;
}
.FunEmojiSelectionText::selection {
background-color: rgba(8, 73, 205, 255);
Copy link
Member

@jamiebuilds-signal jamiebuilds-signal May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also may not need the background-color, I think it's only the color: transparent that is getting used to hide the text version of the emoji

color: transparent;
}
.FunEmojiSelectionText::-moz-selection {
background-color: rgba(8, 73, 205, 255);
color: transparent;
}

Comment on lines +183 to 187
Copy link
Member

@jamiebuilds-signal jamiebuilds-signal May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this. This ::-moz-selection is for Firefox and we only use Chromium inside of Signal Desktop.

.FunInlineEmoji__Image {
position: relative;
Expand Down