Split ORM from Logic

[yelled3]

@seuros take a look

I'm starting to thing this split is an overkill - mostly the ManagerWorker part...
maybe we should just have a gem per-ORM, with some duplications

WDYT?

[seuros]

I will take a look at this today and come back to you. Sorry for delay.

[yelled3]

@seuros no worries, take your time

[yelled3]

perform_bulk will execute N time UserMailerWorker.perform_async

the reason I use Sidekiq::Client.push_bulk is because doing perform_async N times is costly, when N is large.

but other then that perform_bulk is just an alias of perform_query_async, no?

[yelled3]

we can use Activesupport::Concern

I'm trying to minimize dependencies, just like sidekiq is doing:

https://github.com/mperham/sidekiq/blob/ddb58482cfe6b934d632b25c560298c8da4838d8/lib/sidekiq/core_ext.rb#L5

[seuros]

I'm trying to minimize dependencies

You can't, ActiveRecord already loaded ActiveSupport.

[seuros]

but other then that perform_bulk is just an alias of perform_query_async, no?

yes

the reason I use Sidekiq::Client.push_bulk is because doing perform_async N times is costly, when N is large.

That why we should do test with live data.

[yelled3]

That why we should do test with live data.

there's no need to benchmark it - already been done. see:

http://stackoverflow.com/a/20692081
http://www.rubydoc.info/github/mperham/sidekiq/Sidekiq/Client.push_bulk

[yelled3]

continued in: #15