Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

프로필 상세 조회와 프로필 조회에 회사 정보 추가 #69

Merged
merged 2 commits into from
Feb 11, 2024
Merged

프로필 상세 조회와 프로필 조회에 회사 정보 추가 #69

merged 2 commits into from
Feb 11, 2024

Conversation

jacobhboy
Copy link
Member

@jacobhboy jacobhboy commented Feb 11, 2024 •
edited
Loading

🎫 관련 이슈

close #68


🔨 작업 내용

  • 프로필 상세 조회와 프로필 조회에 회사 정보를 추가하였습니다.

🏁 확인 사항

  • 테스트를 완료했나요?
  • API 문서를 작성했나요?
  • 코드 컨벤션을 준수했나요?
  • 불필요한 로그, 주석, import 등을 삭제했나요?

🙋🏻 덧붙일 말

@jacobhboy jacobhboy linked an issue Feb 11, 2024 that may be closed by this pull request
프로필 상세 조회와 프로필 조회에 회사 정보 추가 #68
Closed
SEOKKAMONI
SEOKKAMONI approved these changes Feb 11, 2024
View reviewed changes
Copy link
Member

@SEOKKAMONI SEOKKAMONI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jacobhboy jacobhboy merged commit 8b535ea into master Feb 11, 2024
2 checks passed
jacobhboy added a commit that referenced this pull request Feb 11, 2024
@jacobhboy
Revert "프로필 상세 조회와 프로필 조회에 회사 정보 추가 (#69)"
55c5c0f 
This reverts commit 8b535ea.
jacobhboy added a commit that referenced this pull request Feb 11, 2024
@jacobhboy
profile에 introduction 추가 (#70)
83a0d2a 
* Revert "프로필 상세 조회와 프로필 조회에 회사 정보 추가 (#69)"

This reverts commit 8b535ea.

* refactor(profile): introduction 추가

* refactor(profile): 20자 넘지 않으면 substring하지 않음
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SEOKKAMONI SEOKKAMONI SEOKKAMONI approved these changes

@Woongbin06 Woongbin06 Awaiting requested review from Woongbin06

Assignees

@jacobhboy jacobhboy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

프로필 상세 조회와 프로필 조회에 회사 정보 추가
2 participants
@jacobhboy @SEOKKAMONI