Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

이벤트 크롤링 #52

Merged
merged 5 commits into from
Jan 29, 2024
Merged

이벤트 크롤링 #52

merged 5 commits into from
Jan 29, 2024

Conversation

jacobhboy
Copy link
Member

@jacobhboy jacobhboy commented Jan 29, 2024 •
edited
Loading

🎫 관련 이슈

close #51


🔨 작업 내용

  • 이벤트 정보를 크롤링하는 기능을 구현하였습니다.

🏁 확인 사항

  • 테스트를 완료했나요?
  • API 문서를 작성했나요?
  • 코드 컨벤션을 준수했나요?
  • 불필요한 로그, 주석, import 등을 삭제했나요?

🙋🏻 덧붙일 말

@jacobhboy jacobhboy linked an issue Jan 29, 2024 that may be closed by this pull request
이벤트 크롤링 #51
Closed
2 tasks
@jacobhboy jacobhboy changed the title Feat/#51 이벤트 크롤링 Jan 29, 2024
Woongbin06
Woongbin06 approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@Woongbin06 Woongbin06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다ㅏ~

src/main/java/com/sickgyun/server/event/scheduler/EventScheduler.java Outdated
Comment on lines 32 to 34

@Scheduled(cron = "0 0 5 1 * ?") // 매달 1일 5시
@Transactional
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

크롤링 되는 날은 한 번 얘기해봐야 할 거 같아요. 만약 2월 중순에 시작해서 2월 말에 끝나는 대회 정보 같은 건 확인 할 수 없어요....

@jacobhboy jacobhboy merged commit 9581b93 into master Jan 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Woongbin06 Woongbin06 Woongbin06 approved these changes

Assignees

@jacobhboy jacobhboy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

이벤트 크롤링
2 participants
@jacobhboy @Woongbin06