Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

액세스 토큰 만료시 Refresh 하는 기능 구현 #43

Merged
merged 24 commits into from
Jan 14, 2024
Merged

Conversation

jacobhboy
Copy link
Member

@jacobhboy jacobhboy commented Jan 10, 2024

🎫 관련 이슈

close #42


🔨 작업 내용

  • access token을 refresh하는 기능을 구현하였습니다.

🏁 확인 사항

  • 테스트를 완료했나요?
  • API 문서를 작성했나요?
  • 코드 컨벤션을 준수했나요?
  • 불필요한 로그, 주석, import 등을 삭제했나요?

🙋🏻 덧붙일 말

@jacobhboy jacobhboy linked an issue Jan 10, 2024 that may be closed by this pull request
2 tasks
@jacobhboy jacobhboy requested a review from Woongbin06 January 10, 2024 12:17
Copy link
Contributor

@Woongbin06 Woongbin06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다. 이제 남은 기능 개발 빠르게 해보죠

Comment on lines +46 to +51
String refreshToken = BearerTokenExtractor.extract(bearer);
authValidator.shouldRefreshTokenValid(refreshToken);

Long userId = authReader.getIdFromJwt(refreshToken);
String accessToken = tokenProvider.createAccessToken(userReader.readUser(userId));

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

깔쌈하네요

@jacobhboy jacobhboy merged commit 2e0f94a into master Jan 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

액세스 토큰 만료시 Refresh 하는 기능 구현
2 participants