Add opts as parameter tp self.to_png method, and 'wb' mode for File.read #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. Thank you for this gem. While using it, I faced some error ""\x89" from ASCII-8BIT to UTF-8", after googling i found this solution which solved the problem, so I desided to add some fixes.
Also i found out that it is impossible to pass a dimensions options x_scale and y_scale, so I added them as well, so final result in my code is looking like this
PDF417.to_png('tmp/barcode.png', value, { x_scale: 4, y_scale: 2 })Thank you.