Skip to content

test: implement ATS tests for PayPal#549

Open
Stefan Guder (sguder) wants to merge 9 commits intotrunkfrom
test/implement-ats-tests
Open

test: implement ATS tests for PayPal#549
Stefan Guder (sguder) wants to merge 9 commits intotrunkfrom
test/implement-ats-tests

Conversation

@sguder
Copy link

@sguder Stefan Guder (sguder) commented Feb 11, 2026

1. Why is this change necessary?

2. What does this change do, exactly?

This PR includes preparations like page objects and TestDataService functions, it also includes the CheckExpressButtons Test

3. Describe each step to reproduce the issue or behaviour.

4. Please link to the relevant issues (if any).

5. Checklist

  • I have written tests and verified that they fail without my change
  • I have created an entry in the CHANGELOG.md files with all necessary user information about my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfill them.

@sguder Stefan Guder (sguder) self-assigned this Feb 11, 2026
@sguder Stefan Guder (sguder) added the testing/acceptance Relates to an acceptance test. label Feb 11, 2026
@sguder Stefan Guder (sguder) marked this pull request as draft February 11, 2026 07:46
@sguder Stefan Guder (sguder) marked this pull request as ready for review March 5, 2026 14:06
@sguder Stefan Guder (sguder) requested review from a team and Michel (cyl3x) March 5, 2026 14:06
@@ -0,0 +1,42 @@
# EXAMPLE USAGE:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this file?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I don't know. It was added in ATS

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its not needed

@@ -0,0 +1,42 @@
# EXAMPLE USAGE:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its not needed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure oxlint is nett, but what was the problem with the ESLint setup? Last time I checked ESLint was working fine and type checking and references were working in VS Code 🤔 I'm not as familiar with oxlint as with eslint and cannot tell if the feature compatibility is complete - as all other projects using the test suite (e.g. platform) haven't migrated, I would prefer also not migrating in SwagPayPal due to maintenance overhead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing/acceptance Relates to an acceptance test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants