Open
Conversation
- refactored Line and Oval into their own classes - shape does move_to and line_to, but the groundwork is there for it to do all the rest
This adds move for Shape, Oval, and Button. Shoes-level implementation and an SWT gui implementation. Oval is straghtforward. Shape is somewhat complicated because it moves all elements of the shape. I believe this is a correct, but not optimized implementation. Button is also complicated because Buttons can be laid out in slots. The Button is removed from the slot's layout, so the remaining elements can reflow. The Button's gui element is disposed, and a new gui element is created and added to a new Swt::Composite layer so it is out of the layout flow. This only happens on the first move. Once the Button is in a container without a layout, it continues to use the same gui element. * Add NO_BACKGROUND so layers are transparent. This applies to all flow objects * Adjust framerate to approach Red Shoes. It's still not a perfect match, but it's closer. * Add new working sample: simple-move.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds move for Shape, Oval, and Button. Shoes-level implementation
and an SWT gui implementation. Oval is straghtforward. Shape is
somewhat complicated because it moves all elements of the shape. I
believe this is a correct, but not optimized implementation.
Button is also complicated because Buttons can be laid out in slots.
The Button is removed from the slot's layout, so the remaining elements
can reflow. The Button's gui element is disposed, and a new gui element
is created and added to a new Swt::Composite layer so it is out of the
layout flow. This only happens on the first move. Once the Button is in
a container without a layout, it continues to use the same gui element.
This PR also carries the baggage of the animate one.
It's not actually that big.
Also:
all flow objects
match, but it's closer.
simple-move.rb