Change hard-coded preview data to not hard-coded #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minacle
force-pushed
the
feature/preview-manifest
branch
3 times, most recently
from
43d8d21 to
f242c4d
Compare
|
이렇게 되면 함수를 파트1 파트2 처럼 나눌 수밖에 없어지니 린트는 포기하겠습니다. |
@minacle 제안드리자면, 어차피 프리뷰 데이터인 만큼 Reflection을 써서 값을 대입하는 방법도 있습니다. |
minacle
force-pushed
the
feature/preview-manifest
branch
from
1a1983b to
c1376f4
Compare
minacle
force-pushed
the
feature/preview-manifest
branch
3 times, most recently
from
6c40ef4 to
c96adf3
Compare
minacle
force-pushed
the
feature/preview-manifest
branch
from
c96adf3 to
4986129
Compare
sinoru
requested changes
Jun 3, 2022
.swiftlint.yml
Outdated
| @@ -10,6 +10,10 @@ opt_in_rules: | |||
| - empty_collection_literal | |||
| - empty_string | |||
|
|
|||
| cyclomatic_complexity: | |||
| warning: 20 | |||
There was a problem hiding this comment.
Suggested change
| warning: 20 | |
| warning: 15 |
Comment on lines
+35
to
+36
| context: NSManagedObjectContext? = nil, | ||
| save: Bool = false |
There was a problem hiding this comment.
save parameter를 받는 이유가 있을까요?
There was a problem hiding this comment.
외부에서 context를 제공했을 경우 여러 파일을 한꺼번에 읽어들인 뒤 직접 한 번만 저장할 수도 있습니다.
There was a problem hiding this comment.
context를 받지 않거나, default 값에서 nil 대신 아에 background context를 생성하는 것도 좋을 것 같습니다.
| @@ -0,0 +1,262 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | |||
Comment on lines
+52
to
+82
| let state = _PreviewDataInjectionState(bundle: bundle) | ||
| for (userID, previewUserDetails) in previewManifest.userDetails { | ||
| state.userDetail = nil | ||
| for previewUserDetail in previewUserDetails { | ||
| let userDetail = _injectPreviewUserDetail(previewUserDetail, state: state, context: context) | ||
| if state.userIDToUserDetail[userID] == nil { | ||
| state.userIDToUserDetail[userID] = userDetail | ||
| } | ||
| state.userDetail = userDetail | ||
| } | ||
| } | ||
| for (userID, userDetail) in state.userIDToUserDetail { | ||
| state.userDetail = userDetail | ||
| _injectPreviewUser(id: userID, state: state, context: context) | ||
| } | ||
| for userID in previewManifest.accounts { | ||
| guard let userDetail = state.userIDToUserDetail[userID] else { | ||
| continue | ||
| } | ||
| state.userDetail = userDetail | ||
| _injectPreviewAccount(userID: userID, state: state, context: context) | ||
| } | ||
| for (userID, previewUserDataAssets) in previewManifest.dataAssets { | ||
| guard let userDetail = state.userIDToUserDetail[userID] else { | ||
| continue | ||
| } | ||
| state.userDetail = userDetail | ||
| for previewUserDataAsset in previewUserDataAssets { | ||
| _injectPreviewUserDataAsset(previewUserDataAsset, state: state, context: context) | ||
| } | ||
| } |
There was a problem hiding this comment.
state를 사용하여 넣는 형태가 필요에 비해 과한 것 같습니다.
좀 더 단순하게 할 수 있을 것 같습니다.
There was a problem hiding this comment.
좀 더 단순하게 하면 복잡도가 30에 달합니다.
This reverts commit d2683c2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.