Implement dequantizeLinear #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lisa0314
force-pushed
the
ort_backend
branch
from
c75ee80 to
2bfbb81
Compare
lisa0314
force-pushed
the
ort_backend
branch
from
2bfbb81 to
2b97724
Compare
huningxin
reviewed
Feb 11, 2025
shiyi9801
force-pushed
the
ort_backend
branch
from
7a4f312 to
a97dfb2
Compare
|
You'll need to rebase the code due to my latest force push, thanks! |
lisa0314
force-pushed
the
ort_backend
branch
from
2b97724 to
5f0efb1
Compare
|
@huningxin Please take another look. Thanks! |
|
@huningxin Please hold on. I will upload a new commit to fix a bug. |
|
@huningxin ready for review again. Thanks! |
lisa0314
force-pushed
the
ort_backend
branch
from
c6bc4f9 to
92c4e15
Compare
huningxin
reviewed
Feb 14, 2025
|
@huningxin Uploaded a new commit to address the remaining comments. Please take another look. Thanks! |
huningxin
reviewed
Feb 17, 2025
|
@huningxin Please take another look. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of dequantizelinear is a little confusion since currently WebNN spec definition for dequantizelinear is wildly different from ONNX. Besides, OpenVINO also have many constraints.