feat: add handling for FontStyle.Strikethrough
#976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for shiki-matsu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for shiki-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Oh nice catch! LGTM. Anything left for it to be ready? |
dhruvkb
commented
Mar 25, 2025
There was a problem hiding this comment.
It was actually pointed out to me by @hippotastic in expressive-code/expressive-code#316.
|
|
||
| .vp-code, | ||
| .vp-code span { | ||
| /* background-color: var(--shiki-bg, inherit); */ |
There was a problem hiding this comment.
When this is enabled, ANSI background colors become visible but this breaks all other code examples in the docs.
That's why I've set this disabled currently, but then ANSI background colors don't render at all (and consequently the reversed style).
antfu
changed the title
FontStyle.StrikethroughFontStyle.Strikethrough
antfu
changed the title
FontStyle.StrikethroughFontStyle.Strikethrough
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for handling the
FontStyle.Strikethroughin a few places where it was not present. The primary motivation was to support ANSI strikethrough which is supported by the underlyingansi-sequence-parserpackage but not by Shiki.Linked Issues
Fixes #975 by myself
Additional context
I would appreciate any help in pointing out the new test cases which should be added to cover the changed code (and where to add them).