Skip to content

.NET 8.0 への移行と依存パッケージの最新化 #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shibayan merged 1 commit into from
Apr 18, 2026
Merged

.NET 8.0 への移行と依存パッケージの最新化 #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
branches: [ master ]

env:
DOTNET_VERSION: 7.0.x
DOTNET_VERSION: 8.0.x

Comment on lines 9 to 11

Copilot AI Apr 18, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DOTNET_VERSION を 8.0.x に上げるタイミングで、actions/checkout と actions/setup-dotnet も v4 へ更新しておくのが安全です（v3 系は古い Node ランタイム依存のため、ランナー側の更新で将来的に動かなくなるリスクがあります）。

Copilot uses AI. Check for mistakes.
jobs:
build:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
tags: [ v* ]

env:
DOTNET_VERSION: 7.0.x
DOTNET_VERSION: 8.0.x

Comment on lines 7 to 9

Copilot AI Apr 18, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DOTNET_VERSION を 8.0.x に上げるタイミングで、actions/checkout と actions/setup-dotnet も v4 へ更新しておくのが安全です（v3 系は古い Node ランタイム依存のため、ランナー側の更新で将来的に動かなくなるリスクがあります）。

Copilot uses AI. Check for mistakes.
jobs:
publish:
Expand Down
4 changes: 2 additions & 2 deletions CsvHelper.FastDynamic.Performance/CsvHelper.FastDynamic.Performance.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net7.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="BenchmarkDotNet" Version="0.13.7" />
<PackageReference Include="BenchmarkDotNet" Version="0.15.8" />
</ItemGroup>

<ItemGroup>
Expand Down
8 changes: 4 additions & 4 deletions CsvHelper.FastDynamic.Tests/CsvHelper.FastDynamic.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net7.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>

<IsPackable>false</IsPackable>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.7.2" />
<PackageReference Include="xunit" Version="2.5.0" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.5.0">
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.4.0" />
<PackageReference Include="xunit" Version="2.9.3" />
<PackageReference Include="xunit.runner.visualstudio" Version="3.1.5">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
Expand Down
4 changes: 2 additions & 2 deletions CsvHelper.FastDynamic/CsvHelper.FastDynamic.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>

Copilot AI Apr 18, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ライブラリプロジェクトを単一ターゲットの net8.0 にすると、net6/net7 を含む旧TFMのアプリから参照できなくなるため NuGet 利用者に対して破壊的変更になります。互換性を維持したい場合は multi-target（例: net6.0;net8.0 など）にするか、破壊的変更としてリリース方針（メジャーバージョン更新/リリースノート）を明確にしてください。

Suggested change
<TargetFramework>net8.0</TargetFramework>
<TargetFrameworks>net6.0;net8.0</TargetFrameworks>

Copilot uses AI. Check for mistakes.
<LangVersion>latest</LangVersion>
</PropertyGroup>

Expand All @@ -17,7 +17,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="CsvHelper" Version="30.0.1" />
<PackageReference Include="CsvHelper" Version="33.1.0" />
</ItemGroup>

<ItemGroup>
Expand Down
Loading