Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy warnings and docker CI #54

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@ jobs:
- name: Checkout code
uses: actions/checkout@master

- name: Run docker-compose
run: docker-compose -f docker-compose.yml up --abort-on-container-exit
- name: Run docker compose
run: docker compose -f docker-compose.yml up --abort-on-container-exit
8 changes: 2 additions & 6 deletions src/options.rs
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,7 @@ pub fn parse(args: Vec<String>) -> Result<Options, Action> {
for arg in args {
match state {
ParseState::Command => {
let mut command = if let Some(command) = options.command.take() {
command
} else {
vec![]
};
let mut command = options.command.take().unwrap_or_default();
command.push(arg);
options.command = Some(command);
}
Expand All @@ -56,7 +52,7 @@ pub fn parse(args: Vec<String>) -> Result<Options, Action> {
_ => {
options
.to_check
.push(arg.parse::<ToCheck>().map_err(|e| Action::Failed(e))?);
.push(arg.parse::<ToCheck>().map_err(Action::Failed)?);
}
},
}
Expand Down
1 change: 1 addition & 0 deletions src/scanner.rs
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,7 @@ impl Wait {
}
}

#[allow(dead_code)]
pub trait Generator {
fn generate_tick(&mut self) -> Pin<Box<dyn Future<Output = ()>>>;
fn generate_error(&mut self) -> Pin<Box<dyn Future<Output = ()>>>;
Expand Down