Skip to content

Add support for oklab and oklch color formats #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

EdMSL
Copy link

@EdMSL EdMSL commented Jun 13, 2025

This PR contains:

  • bugfix
  • [*] feature
  • refactor
  • [*] tests
  • documentation
  • metadata

Breaking Changes?

  • yes
  • [*] no

If yes, please describe the breakage.

Please Describe Your Changes

Added support for oklab and oklch color formats to detect as node.isColor.

@EdMSL EdMSL changed the title Okcolor Add support for oklab and oklch color formats Jun 14, 2025
@shellscape
Copy link
Owner

Thanks for the PR. It looks like you need to run tests locally and create and commit the snapshots. Please do that.

@EdMSL
Copy link
Author

EdMSL commented Jun 17, 2025

If I run npm test I get "No tests found in" for every file.
Uncaught exception in test\word.test.js

Error: Package subpath './lib/input' is not defined by "exports" in E:\Projects\postcss-values-parser\node_modules\postcss\package.json

@shellscape
Copy link
Owner

That's odd. CI seems to have no problem running tests. Perhaps something is sideways on your local system?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants