bump: release `v1.1.0` by shawntz · Pull Request #8 · shawntz/cassh

shawntz · 2025-12-13T01:35:14Z

Description

Type of Change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update
Refactoring (no functional changes)

Related Issues

Closes #

How Has This Been Tested?

Unit tests
Integration tests
Manual testing

Test environment:

OS:
Go version:

Checklist

My code follows the project's style guidelines
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published

Security Considerations

This PR does not introduce any security concerns
I have considered the security implications and addressed them

Screenshots (if applicable)

Bumps the go_modules group with 1 update in the / directory: [golang.org/x/oauth2](https://github.com/golang/oauth2). Updates `golang.org/x/oauth2` from 0.20.0 to 0.27.0 - [Commits](golang/oauth2@v0.20.0...v0.27.0) --- updated-dependencies: - dependency-name: golang.org/x/oauth2 dependency-version: 0.27.0 dependency-type: direct:production dependency-group: go_modules ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps the go_modules group with 1 update in the / directory: [github.com/go-jose/go-jose/v4](https://github.com/go-jose/go-jose). Updates `github.com/go-jose/go-jose/v4` from 4.0.1 to 4.0.5 - [Release notes](https://github.com/go-jose/go-jose/releases) - [Commits](go-jose/go-jose@v4.0.1...v4.0.5) --- updated-dependencies: - dependency-name: github.com/go-jose/go-jose/v4 dependency-version: 4.0.5 dependency-type: indirect dependency-group: go_modules ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps the go_modules group with 1 update in the / directory: [golang.org/x/crypto](https://github.com/golang/crypto). Updates `golang.org/x/crypto` from 0.23.0 to 0.45.0 - [Commits](golang/crypto@v0.23.0...v0.45.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-version: 0.45.0 dependency-type: direct:production dependency-group: go_modules ... Signed-off-by: dependabot[bot] <support@github.com>

Implemented SSH key revocation for personal GitHub connections, including removal from ssh-agent, GitHub, and local files. Updated menu item text and tooltips to distinguish between certificate and key revocation, and ensured UI status updates after key actions.

…85326579b chore: bump golang.org/x/oauth2 from 0.20.0 to 0.27.0 in the go_modules group across 1 directory

Copilot

Pull request overview

This PR bumps the project version to v1.1.0 by updating the Go toolchain version and upgrading a key dependency. The changes prepare the codebase for using newer Go language features and updated OAuth2 library functionality.

Updates Go toolchain from 1.22 to 1.23.0
Upgrades golang.org/x/oauth2 from v0.20.0 to v0.27.0
Updates go.sum checksums to reflect the dependency changes

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File	Description
go.mod	Updates Go version directive to 1.23.0 and golang.org/x/oauth2 to v0.27.0
go.sum	Updates checksums for golang.org/x/oauth2 v0.27.0 to match the dependency upgrade

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-13T01:37:26Z

go.mod

 module github.com/shawntz/cassh

-go 1.22
+go 1.23.0


The Go version directive should not include the patch version. According to Go module conventions, the version should be specified as go 1.23 rather than go 1.23.0. Go toolchain versions are specified as major.minor only in go.mod files.

Suggested change

go 1.23.0

go 1.23

chore: bump github.com/go-jose/go-jose/v4 from 4.0.1 to 4.0.5 in the go_modules group across 1 directory

chore: bump golang.org/x/crypto from 0.23.0 to 0.45.0 in the go_modules group across 1 directory

fix: correct personal SSH key PEM encoding

Copilot

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…31551 chore: add claude code GitHub actions workflows

Bumps the go_modules group with 3 updates in the / directory: [golang.org/x/crypto](https://github.com/golang/crypto), [golang.org/x/oauth2](https://github.com/golang/oauth2) and [github.com/go-jose/go-jose/v4](https://github.com/go-jose/go-jose). Updates `golang.org/x/crypto` from 0.23.0 to 0.45.0 - [Commits](golang/crypto@v0.23.0...v0.45.0) Updates `golang.org/x/oauth2` from 0.20.0 to 0.27.0 - [Commits](golang/oauth2@v0.20.0...v0.27.0) Updates `github.com/go-jose/go-jose/v4` from 4.0.1 to 4.0.5 - [Release notes](https://github.com/go-jose/go-jose/releases) - [Commits](go-jose/go-jose@v4.0.1...v4.0.5) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-version: 0.45.0 dependency-type: direct:production dependency-group: go_modules - dependency-name: golang.org/x/oauth2 dependency-version: 0.27.0 dependency-type: direct:production dependency-group: go_modules - dependency-name: github.com/go-jose/go-jose/v4 dependency-version: 4.0.5 dependency-type: indirect dependency-group: go_modules ... Signed-off-by: dependabot[bot] <support@github.com>

…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

Potential fix for code scanning alert no. 5: Workflow does not contain permissions

…6d-4361-adc9-a7cba3b0d07d

…361-adc9-a7cba3b0d07d Add token validation to GitLab NewClient constructor

…cation function calls Co-authored-by: shawntz <5200266+shawntz@users.noreply.github.com>

Co-authored-by: shawntz <5200266+shawntz@users.noreply.github.com>

Make update check interval dynamically reload from config

…4-2797e7c7-141a-45f3-b59e-b0786e2211bd

…5f3-b59e-b0786e2211bd Fix race conditions in update checker goroutines

…96-4aec-9cd3-2c5887f6add2

…aec-9cd3-2c5887f6add2 Handle io.ReadAll errors in GitLab client error paths

…e1-4e91-9be8-09ae53eb513b

…e91-9be8-09ae53eb513b Handle io.ReadAll errors in GitLab client error paths

…c47-bced-a42be8309a2e Wire up MigrateDeprecatedFields to LoadUserConfig

…0d-4c25-8209-ebf1f113a75a

…c25-8209-ebf1f113a75a Sanitize GitLab API error messages to prevent sensitive data exposure

shawntz · 2026-01-01T10:42:33Z

fizzy

Add test coverage for GitLab API client

Add test coverage for SignPublicKeyForGitLab

Optimize GitLab CreateSSHKey to avoid unnecessary API calls

…4-one-more-time

Remove unused identifier parameter from sendNativeNotification

Add persistent update notifications and config options

Add initial GitLab platform support and documentation

Copilot

Pull request overview

Copilot reviewed 21 out of 22 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-11T08:54:59Z

cmd/cassh-menubar/updater.go

+	lastCheckTime := time.Unix(cfg.User.LastUpdateCheckTime, 0)
+	checkIntervalDays := cfg.User.UpdateCheckIntervalDays
+	cfgMutex.RUnlock()
+
+	if !updateCheckEnabled {
+		log.Printf("Update checks disabled by user")
+		return false
+	}
+
+	// Check if we should check for updates based on interval
+	cfgMutex.RLock()
+	lastCheckTime := time.Unix(cfg.User.LastUpdateCheckTime, 0)


The variable lastCheckTime is declared twice in this function. The first declaration on line 183 is shadowed by the second declaration on line 194, making the first one effectively unused.

Copilot · 2026-01-11T08:54:59Z

cmd/cassh-menubar/updater.go

+			if err := config.SaveUserConfig(userCfg); err != nil {
+				log.Printf("Failed to save config after periodic update check: %v", err)
+			}
+			cfgMutex.Unlock()


Mutex lock is acquired but never released. The cfgMutex.Lock() on line 352 is followed by an immediate cfgMutex.Unlock() on line 352 without any code in between, and then there's unreachable code after. This appears to be a copy-paste error.

Copilot · 2026-01-11T08:54:59Z

cmd/cassh-menubar/updater.go

+		}
+		sendNativeNotification("Update Dismissed", fmt.Sprintf("You can check for updates again from the menu.\n\nDismissed version: v%s", currentLatestVersion))
+	}
+	cfgMutex.Unlock()


Mutex acquired but never released. The function acquires cfgMutex.Lock() on line 479 but then releases it on line 500 after the function returns, making line 500 unreachable.

Suggested change

cfgMutex.Unlock()

Copilot · 2026-01-11T08:55:00Z

cmd/cassh-menubar/updater.go

+	cfgMutex.RLock()
+	lastCheckTime := time.Unix(cfg.User.LastUpdateCheckTime, 0)
+	cfgMutex.RUnlock()


This variable is declared but never used in the function. The parameter dismissedVersion from the RLock is read but cfgMutex.RLock() is called again without unlocking, leading to a potential deadlock.

Copilot · 2026-01-11T08:55:00Z

cmd/cassh-menubar/main.go


 var (
 	cfg        *config.MergedConfig
+	cfgMutex   sync.RWMutex // Protects concurrent access to cfg.User


The cfgMutex variable is declared twice in this file - once in the global scope (line 55) and once in updater.go (line 52). This will cause compilation errors or unexpected behavior due to shadowing.

Suggested change

cfgMutex sync.RWMutex // Protects concurrent access to cfg.User

Copilot · 2026-01-11T08:55:00Z

internal/ca/ca_test.go

+
+	// Verify login extension still uses the username
+	loginValue, ok := cert.Extensions["login@gitlab.com"]
+	if !ok {
+		t.Error("Missing GitLab login extension: login@gitlab.com")
+	}
+	if loginValue != "gitlabuser" {
+		t.Errorf("Login extension = %q, want %q", loginValue, "gitlabuser")
+	}


Test code contains unreachable statements and logic errors. Lines 484-491 are unreachable because the closing brace on line 482 ends the function, and the test logic appears to be duplicated or incorrectly structured.

Suggested change

// Verify login extension still uses the username

loginValue, ok := cert.Extensions["login@gitlab.com"]

if !ok {

t.Error("Missing GitLab login extension: login@gitlab.com")

}

if loginValue != "gitlabuser" {

t.Errorf("Login extension = %q, want %q", loginValue, "gitlabuser")

}

}

Copilot · 2026-01-11T08:55:01Z

cmd/cassh-menubar/updater_test.go

+	configMutex.RLock()
+	dismissedVersion := cfg.User.DismissedUpdateVersion


The variable configMutex is used in this file but is declared as cfgMutex in the global scope. Either the variable name is inconsistent or this is shadowing the global variable. This should use cfgMutex to match the global declaration.

dependabot bot and others added 9 commits December 7, 2025 22:39

BF: personal github key corruption

19f5acf

"Claude PR Assistant workflow"

b74c8bc

"Claude Code Review workflow"

25e7d00

Pass connection index to handleConnectionAction

1806d31

Merge pull request #1 from shawntz/dependabot/go_modules/go_modules-9…

a436cb9

…85326579b chore: bump golang.org/x/oauth2 from 0.20.0 to 0.27.0 in the go_modules group across 1 directory

shawntz self-assigned this Dec 13, 2025

Copilot AI review requested due to automatic review settings December 13, 2025 01:35

shawntz added the release label Dec 13, 2025

Copilot started reviewing on behalf of shawntz December 13, 2025 01:35 View session

Copilot AI reviewed Dec 13, 2025

View reviewed changes

shawntz added 4 commits December 12, 2025 17:38

Merge branch 'staging' into fix/merge-conflicts

c7ffeec

Merge pull request #2 from shawntz/fix/merge-conflicts

b6dfa10

chore: bump github.com/go-jose/go-jose/v4 from 4.0.1 to 4.0.5 in the go_modules group across 1 directory

Merge branch 'staging' into fix/merge-conflicts

2cd8253

Merge pull request #3 from shawntz/fix/merge-conflicts

0e4b9f4

chore: bump golang.org/x/crypto from 0.23.0 to 0.45.0 in the go_modules group across 1 directory

Copilot AI review requested due to automatic review settings December 13, 2025 01:42

Copilot started reviewing on behalf of shawntz December 13, 2025 01:42 View session

Merge pull request #4 from shawntz/fix-personal-gh-key

788a7fb

fix: correct personal SSH key PEM encoding

Copilot AI reviewed Dec 13, 2025

View reviewed changes

shawntz and others added 8 commits December 12, 2025 17:44

Apply suggestions from code review

5739b0d

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Merge pull request #6 from shawntz/add-claude-github-actions-17652484…

ed9d877

…31551 chore: add claude code GitHub actions workflows

Potential fix for code scanning alert no. 5: Workflow does not contai…

3830439

…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

Potential fix for code scanning alert no. 4: Workflow does not contai…

14954db

…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

Potential fix for code scanning alert no. 3: Workflow does not contai…

e37c046

…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

Potential fix for code scanning alert no. 2: Workflow does not contai…

0c1f2f0

…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

Merge pull request #10 from shawntz/alert-autofix-5

6acc535

Potential fix for code scanning alert no. 5: Workflow does not contain permissions

shawntz and others added 15 commits December 20, 2025 16:16

Merge branch 'feat/gitlab-support' into copilot/sub-pr-33-4ecc6a27-27…

c2b61ae

…6d-4361-adc9-a7cba3b0d07d

Merge pull request #50 from shawntz/copilot/sub-pr-33-4ecc6a27-276d-4…

0c11905

…361-adc9-a7cba3b0d07d Add token validation to GitLab NewClient constructor

Fix compilation errors: rename configMutex to cfgMutex and fix notifi…

edd02e9

…cation function calls Co-authored-by: shawntz <5200266+shawntz@users.noreply.github.com>

Merge branch 'feat/better-update-notif-support' into copilot/sub-pr-34

2c21e31

Remove duplicate function and redundant config reads

1e069b9

Co-authored-by: shawntz <5200266+shawntz@users.noreply.github.com>

Merge pull request #35 from shawntz/copilot/sub-pr-34

1e24882

Make update check interval dynamically reload from config

Merge branch 'feat/better-update-notif-support' into copilot/sub-pr-3…

ec216b0

…4-2797e7c7-141a-45f3-b59e-b0786e2211bd

Merge pull request #59 from shawntz/copilot/sub-pr-34-2797e7c7-141a-4…

358e9b2

…5f3-b59e-b0786e2211bd Fix race conditions in update checker goroutines

Merge branch 'feat/gitlab-support' into copilot/sub-pr-33-50ee55d5-2e…

0b4d9bc

…96-4aec-9cd3-2c5887f6add2

Merge pull request #49 from shawntz/copilot/sub-pr-33-50ee55d5-2e96-4…

3137f9f

…aec-9cd3-2c5887f6add2 Handle io.ReadAll errors in GitLab client error paths

Merge branch 'feat/gitlab-support' into copilot/sub-pr-33-96bb12d4-87…

8daf69c

…e1-4e91-9be8-09ae53eb513b

Merge pull request #48 from shawntz/copilot/sub-pr-33-96bb12d4-87e1-4…

147a830

…e91-9be8-09ae53eb513b Handle io.ReadAll errors in GitLab client error paths

Merge pull request #47 from shawntz/copilot/sub-pr-33-0ec97188-4ad5-4…

23ebcb8

…c47-bced-a42be8309a2e Wire up MigrateDeprecatedFields to LoadUserConfig

Merge branch 'feat/gitlab-support' into copilot/sub-pr-33-aff4835f-67…

5546f59

…0d-4c25-8209-ebf1f113a75a

Merge pull request #46 from shawntz/copilot/sub-pr-33-aff4835f-670d-4…

346e13b

…c25-8209-ebf1f113a75a Sanitize GitLab API error messages to prevent sensitive data exposure

shawntz added 11 commits January 10, 2026 23:01

Merge branch 'feat/gitlab-support' into copilot/sub-pr-33-please-work

ed7eadb

Merge pull request #45 from shawntz/copilot/sub-pr-33-please-work

ec8a572

Add test coverage for GitLab API client

Merge branch 'feat/gitlab-support' into copilot/sub-pr-33-one-more-time

3732539

Merge pull request #44 from shawntz/copilot/sub-pr-33-one-more-time

6950d2a

Add test coverage for SignPublicKeyForGitLab

Merge branch 'feat/gitlab-support' into copilot/sub-pr-33

4256ae5

Merge pull request #40 from shawntz/copilot/sub-pr-33

740fc76

Optimize GitLab CreateSSHKey to avoid unnecessary API calls

Merge branch 'feat/better-update-notif-support' into copilot/sub-pr-3…

c8800f2

…4-one-more-time

Merge pull request #39 from shawntz/copilot/sub-pr-34-one-more-time

91f4f6e

Remove unused identifier parameter from sendNativeNotification

Merge pull request #34 from shawntz/feat/better-update-notif-support

c33287d

Add persistent update notifications and config options

Merge branch 'staging' into feat/gitlab-support

cb1d608

Merge pull request #33 from shawntz/feat/gitlab-support

816aa75

Add initial GitLab platform support and documentation

Copilot AI review requested due to automatic review settings January 11, 2026 08:51

Copilot started reviewing on behalf of shawntz January 11, 2026 08:52 View session

Copilot AI reviewed Jan 11, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

bump: release `v1.1.0`#8

bump: release `v1.1.0`#8
shawntz wants to merge 185 commits intomainfrom
staging

shawntz commented Dec 13, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 13, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

shawntz commented Jan 1, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 11, 2026

Uh oh!

Copilot AI Jan 11, 2026

Uh oh!

Copilot AI Jan 11, 2026

Uh oh!

Copilot AI Jan 11, 2026

Uh oh!

Copilot AI Jan 11, 2026

Uh oh!

Copilot AI Jan 11, 2026

Uh oh!

Copilot AI Jan 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		configMutex.RLock()
		dismissedVersion := cfg.User.DismissedUpdateVersion

Uh oh!

Conversation

shawntz commented Dec 13, 2025

Description

Type of Change

Related Issues

How Has This Been Tested?

Checklist

Security Considerations

Screenshots (if applicable)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

shawntz commented Jan 1, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants