Add WKUIDelegate to handle JavaScript alerts and confirms#65
Open
Add WKUIDelegate to handle JavaScript alerts and confirms#65
Conversation
WKWebView requires a UI delegate to handle alert() and confirm() dialogs. Without it, these calls silently fail - causing the connection remove button to do nothing since confirm() returned undefined.
There was a problem hiding this comment.
Pull request overview
This PR adds WKUIDelegate support to enable JavaScript alert() and confirm() dialogs in the WKWebView, fixing a bug where the connection remove button was non-functional because confirm() calls were silently failing.
Changes:
- Added WebViewUIDelegate class implementing WKUIDelegate protocol to handle JavaScript alerts and confirms
- Implemented alert and confirm panel handlers using NSAlert
- Initialized and assigned the UI delegate to the webView instance
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
WKWebView requires a UI delegate to handle alert() and confirm() dialogs. Without it, these calls silently fail - causing the connection remove button to do nothing since confirm() returned undefined.