Skip to content

RadarAxis calls onAxisLabelClick on mouseover #13

Description

@matthewcocco

In the v-next branch, the RadarAxis component calls the onClick method on mouseover.

I believe the cause is here: https://github.com/shauns/react-d3-radar/blob/v-next/src/RadarAxis.js#L71-L72

This causes (what I think is) unexpected behavior for an onAxisLabelClick prop passed from the top level Radar is triggered every time an axis label is moused over, in addition to when it is clicked.

The relevant changes to add an onAxisLabelMouseover prop and pass that value instead to the onMouseover of the RadarAxis component are in:

  • RadarAxis.js
  • Radar.js
  • RadarWrapper.js

I have some changes at matthewcocco@8431850 that pass the test:all suite, and can open a PR if you'd like, @shauns -- would you be open to accepting it?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions