Conversation
sharkdp
force-pushed
the
fix/reference-relative-ratios
branch
2 times, most recently
from
October 5, 2026 09:10
640e849 to
fe64167
Compare
sharkdp
marked this pull request as ready for review
October 5, 2026 09:14
sharkdp
force-pushed
the
fix/reference-relative-ratios
branch
from
October 5, 2026 10:56
fe64167 to
0d89bbc
Compare
sharkdp
force-pushed
the
fix/reference-relative-ratios
branch
from
October 5, 2026 12:20
0d89bbc to
7167df6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
--sort command --reference 'sleep 2' 'sleep 1' 'sleep 3', the comparison currently shows both other commands with ratios above 1, obscuring which is faster. Compute runtime divided by reference runtime so the table shows 1.00, 0.50, and 1.50, with uncertainty scaled consistently. Preserve the prose summary's “times faster/slower” wording.Make Markdown, AsciiDoc, and Org mode exports honor
--referenceand use the same ratios, regardless of sort order. Document the meaning of values below 1.Validation: all 124 tests pass. Regression coverage uses
insta-cmdfor the terminal report and inline Insta snapshots for Markdown file/stdout exports across all sort modes, with additional tests for uncertainty, missing standard deviations, and zero runtimes.cargo clippy --locked --all-targets,cargo fmt -- --check, andgit diff --checkpass.Fixes #811.