Typescript Re-Write #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and make it more spec-compliant, add RGBA output byte order option
add badges
pixelate the map
|
@shaozilee thoughts? |
BobBuehler
reviewed
Nov 5, 2018
|
|
||
| private parseRGBA() { | ||
| this.data = Buffer.alloc(this.width * this.height * 4); | ||
|
|
There was a problem hiding this comment.
A nice additional feature to support is blank space at the end of the header. You can achieve this by using the offset that you parsed earlier and moving pos to that location before extracting pixel data.
Suggested change
| this.pos = this.offset; |
|
I need the mask support that this adds as well as the offset support that I just suggested. |
|
@hipstersmoothie would you release it as bmp-ts ? |
|
@BobBuehler @thbl I have released my fork as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a rewrite of the library in typescript. It helps formalize the code a little bit.
Things I added:
I understand if you don't want to merge this. I can release it as
bmp-tsif you decide not to. If you do decide you are okay with merging this I need to change a few things back but it shouldn't be hard.Thanks for the awesome library!