🧹 [code health improvement] Remove unused AnthropicStreamEvent type#22
🧹 [code health improvement] Remove unused AnthropicStreamEvent type#22shantoislamdev wants to merge 2 commits into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4b08085acd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| cache_read_input_tokens?: number; | ||
| } | ||
|
|
||
| // Streaming event types |
There was a problem hiding this comment.
Because package.json exposes dist/index.d.ts and src/index.ts re-exports ./types, this type was part of the package's public TypeScript API rather than only internal dead code. Any downstream consumer doing import type { AnthropicStreamEvent } from 'claude-adapter' to type SSE handlers will now fail to type-check even though the individual event interfaces still exist, so this is a breaking change unless it is intentionally coordinated with a major release/deprecation.
Useful? React with 👍 / 👎.
1 participant
🎯 What: Removed the unused
AnthropicStreamEventexport type fromsrc/types/anthropic.ts.💡 Why: This type was defined but not utilized anywhere in the codebase. Removing dead code improves readability and maintainability.
✅ Verification: Verified that the code builds (
npm run build) and passes all tests (npm run testandnpm run test -- --coverage) successfully without this type.✨ Result: A cleaner type definition file and improved code health.
PR created automatically by Jules for task 4851406197394779149 started by @shantoislamdev