Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s47036219 ADNI VQ-VAE Connor Armstrong #161

Open
wants to merge 20 commits into
base: topic-recognition
Choose a base branch
from

Conversation

ConnorArmstrong
Copy link

Connor Armstrong - s47036219

The following is my implementation of a Vector Quantized Variational Autoencoder acting on the ADNI brain dataset.
If anything else is needed (like the saved weights) please let me know.

I have an extension making the due date the 24/10/2023.

Thank you in advance.

@SiyuLiu0329
Copy link
Collaborator

SiyuLiu0329 commented Nov 8, 2023

This is an initial inspection, no action is required at this point

Difficulty: Hard

Readme Overall: 
Good

  • Project Overview: Good
  • Model: Good
  • Data + Preprocessing: no description of data preprocessing
  • Training / Loss Curve(s): no graph(s)
    - Result Demonstration: missing results for image generation
  • References: Good

Functionality:

  • Reconstruction: Good
    - Generation: not completed, no pixelcnn

Code:

  • Consistent with Results: Yes
  • File Structure: Okay, but you should put png files in a separate folder.
  • Commenting: Good
  • Commit frequency: Not frequent (1 day)
  • Commit messages: Not descriptive enough

Other Comments:
Please remove .gitignore file from the root directory, you can only make changes to your folder

@shakes76
Copy link
Owner

Marking

Good Practice (Design/Commenting, TF/Torch Usage)

Adequate design and implementation
Good spacing and comments
Header blocks missing -1

Recognition Problem

Solves problem but no generation results -2
Driver Script present
File structure present
Shows Usage & Demo & Visualisation & Data usage, no plots -2
Module present
Commenting
No Data leakage
Difficulty: Hard

Commit Log

Meaningful commit messages sometimes -1
Progressive commits used, but all in one day -1

Documentation

ReadMe acceptable/good
Model/technical explanation
Good Description and Comments
Markdown used and PDF submitted

Pull Request

Successful Pull Request (Working Algorithm Delivered on Time in Correct Branch)
No Feedback required
Request Description minimal -1

@shakes76 shakes76 added the question Further information is requested label Nov 20, 2023
@shakes76
Copy link
Owner

Please remove gitignore files from parent directory for merge. Doesnt affect grade only merge.

@wangzhaomxy
Copy link
Collaborator

No feedback attempt and no feedback marks lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested VQVAE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants