Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect_lesions_s4770608 #147

Open
wants to merge 10 commits into
base: topic-recognition
Choose a base branch
from
Open

Conversation

baibizhe
Copy link

No description provided.

@nathasha-naranpanawa
Copy link
Collaborator

This is an initial inspection, no action is required at this point

Difficulty: Normal

Readme: 
OK

  • no insights/discussion/interpretation of results
  • some training loss and accuracy(mAP) plots shown, but not sure what they mean
  • no detection results shown (embedded images are not appearing in the readme)

Commit messages: 
Poor

  • only 10 commits made within 5 days
  • limited descriptions

Code:

  • No hyperparameter tuning or attempts to improve performance
  • Some comments are present, both in English and Chinese(?)

Functionality/Performance:

  • all average metrics are below expected
  • no classification accuracy given

@shakes76
Copy link
Owner

Marking

Good Practice (Design/Commenting, TF/Torch Usage)

Adequate design and implementation
Good spacing and comments
Header blocks missing -1

Recognition Problem

Solves problem
Driver Script present
File structure present
Shows Usage & Demo & Visualisation & Data usage, results not visualisaed -1
Module present
Commenting sometimes -1
No Data leakage
Difficulty: Normal -5

Commit Log

Meaningful commit messages
Progressive commits used, but only 10, minimal logs -1

Documentation

ReadMe acceptable, broken image links -1
Model/technical explanation
Good Description and Comments
Markdown used and PDF submitted

Pull Request

Successful Pull Request (Working Algorithm Delivered on Time in Correct Branch)
No Feedback required
Request Description not given -2

@shakes76
Copy link
Owner

Please remove gitignore file for mergeing, does not affect grade only merge.

@shakes76 shakes76 added the question Further information is requested label Nov 20, 2023
@wangzhaomxy
Copy link
Collaborator

No feedback attempt and no feedback marks lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mask RCNN question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants