-
-
Notifications
You must be signed in to change notification settings - Fork 427
FFmpeg / build improvements #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
FFmpeg / build improvements #388
Conversation
|
Might be worth to include the ffmpeg exe itself too, so that everyone is on the same page |
|
To be honest I don't like the idea to include that binary in the source control. But maybe we could update the README.md file instead with instructions from where ffmpeg.exe can be obtained and which version are we currently using (both for development and the installer). |
1348da3 to
070ab49
Compare
|
I guess we can include a link to the ffmpeg version we're using, the only problem with that would be that its not guaranteed to always be available, and in the future there might be breaking changes in the latest versions of ffmpeg. But since its very unlikely to happen, we can include a link to ffmpeg in the README.md file. I usually take my builds from https://github.com/sudo-nautilus/FFmpeg-Builds-Win32/releases because its 32 bit, meaning it will work on all machines. The problem with that is that repository is mostly dead and outdated. Lets include both the 32 bit release of ffmpeg from the repository I linked and the latest ffmpeg master build from https://www.gyan.dev/ffmpeg/builds/ffmpeg-git-full.7z (which is 64 bit) Please update the readme.md to include the instructions on downloading/copying ffmpeg to the correct directory |
|
I use this one https://github.com/BtbN/FFmpeg-Builds. I see that sudo-nautilus/FFmpeg-Builds-Win32 also uses BtbN:master. Security-wise I don't trust it 100%. This is why I don't want to put it into the repository. |
|
I hadn't had a chance to work on this yet. Maybe in the following days. |
|
No rush, its ok even if it takes a couple of months, The PR is not going anywhere |
- added PostBuild target to copy ffmpeg.exe to the build folder; - updated the installer file to remove ffmpeg.exe as it is picked from the build folder instead; - both InstallerOutput and FFmpeg folders are now created on git checkout, but their content is ignored by the source control.
070ab49 to
990f50a
Compare
This completes the work done in #266.
Now there is a single source for ffmpeg.exe, both for the installer and for when you run the app from VS. Also, you don't have to manually copy ffmpeg.exe into the build folder anymore.