Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text fields in admin area #11

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

langalex
Copy link
Contributor

Summary

  • add a missing lQuery import
  • change 2 SCSS imports so they actually are SCSS imports and not CSS imports left to the browres to resolve (which fails)

fix #8

@avonderluft
Copy link
Collaborator

@langalex in order to validate with a new Rails 8 project, I want to:
gem "comfortable_media_surfer", git: "https://github.com/cobot/comfortable-media-surfer", branch: "fix-redactor"
but then bundle fails with /bin/sh: esbuild: command not found

@langalex
Copy link
Contributor Author

@avonderluft yep, see #8 (comment)

I can add a Rake task tomorrow

@langalex
Copy link
Contributor Author

@langalex in order to validate with a new Rails 8 project, I want to: gem "comfortable_media_surfer", git: "https://github.com/cobot/comfortable-media-surfer", branch: "fix-redactor" but then bundle fails with /bin/sh: esbuild: command not found

actually for it to work straight from github we"d have to add the compiled assets to git.

the alternative is to check out the surfer repo and reference it in your app's Gemfile via path instead of git. This way you can compile the assets locally in the surfer directory.

what should it be?

@avonderluft
Copy link
Collaborator

@Judahmeek , @justin808 - what do you guys think about Alex's query, viz. add the compiled assets to source control in order to be able to reference the repo in a Gemfile, or not.

@Judahmeek
Copy link
Collaborator

@avonderluft personally, I think the decision is up to you since you've been the primary maintainer.

I've pinged Justin on Slack regarding this conversation, however, so we should have his opinion soon.

@justin808
Copy link
Member

Is there any alternative to avoid the duplication of including the compiled assets in git?

There are many reasons that compiled assets in the version history is annoying and to be avoided.

Potentially we could build it as part of the gem?

@langalex
Copy link
Contributor Author

@justin808 that was my other idea. Create a Rake task to compile the assets when building the gem. The downside is that when you try to use the gem in a Gemfile via git the gem has not een built and so the assets are missing.

I could also try to make compiling the assets in the .gemspec file more robust, e.g. by also installing npm packages within it. But imho there would always be gaps.

@langalex
Copy link
Contributor Author

Turns out there is a post install hook for gems. Will try that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems with version 3.1.0
4 participants