-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix text fields in admin area #11
base: master
Are you sure you want to change the base?
Conversation
@langalex in order to validate with a new Rails 8 project, I want to: |
@avonderluft yep, see #8 (comment) I can add a Rake task tomorrow |
actually for it to work straight from github we"d have to add the compiled assets to git. the alternative is to check out the surfer repo and reference it in your app's Gemfile via what should it be? |
@Judahmeek , @justin808 - what do you guys think about Alex's query, viz. add the compiled assets to source control in order to be able to reference the repo in a Gemfile, or not. |
@avonderluft personally, I think the decision is up to you since you've been the primary maintainer. I've pinged Justin on Slack regarding this conversation, however, so we should have his opinion soon. |
Is there any alternative to avoid the duplication of including the compiled assets in git? There are many reasons that compiled assets in the version history is annoying and to be avoided. Potentially we could build it as part of the gem? |
@justin808 that was my other idea. Create a Rake task to compile the assets when building the gem. The downside is that when you try to use the gem in a Gemfile via I could also try to make compiling the assets in the |
Turns out there is a post install hook for gems. Will try that. |
Summary
fix #8