Enable slangpy_tests on Metal and Run test_buffer_views on macOS
#211
+3
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver-batchelor
pushed a commit
to oliver-batchelor/slangpy
that referenced
this pull request
Jun 3, 2025
* add slang-rhi submodule * replace slang-gfx with slang-rhi * wip * more wip * more porting * more fixes * sgl library compiles (with cuda disabled) * simple compute example working * update slang-rhi * add shared buffer/texture usage * port graphics_pipeline example * port tinybc example * move DrawArguments * update slang-rhi * piggy back on slang-rhi cuda driver aPI * fix shader target setup * update slang-rhi * update submit * wip porting python bindings * mac fixes * compiling partial python extension * successfully compile python ext * more python bindings * remove obsolete bindings * update slang-rhi * more work on bindings * fixup * wip * raytracing working * fix print * cleanup * use vulkan headers from slang-rhi * remove vulkan-headers submodule * fix print example * update texture formats * update types * wip * Fix texture access tests * Fix dds textures (shader-slang#211) * Fixed texture upload operation + made dds texture tests work properly * Update submodules * Fix blending (shader-slang#212) * Fixed texture upload operation + made dds texture tests work properly * Update submodules * Blend modes work + depth working on d3d * Fix vulkan depth textures * Fix alpha coverage test * Blend modes work + depth working on d3d * Fix vulkan depth textures * Fix alpha coverage test * Fix raytracing (shader-slang#213) * Compute ray tracing working * RT pipeline tests workings * Fix Vulkan atomic texture test * Convert torch test to use explicit syncs (#214) * Fix NVAPI (shader-slang#215) * fix nvapi support * fix formatting * Run CI (shader-slang#217) * mac fix * disable python type checks --------- Co-authored-by: Simon Kallweit <[email protected]> * linux fix * export BufferView * gcc fix * formatting * gcc fix * export BufferOffsetPair * cooperative vector support (shader-slang#218) * add cooperative vector support * update slang-rhi * Fix gcc (shader-slang#220) * update slang-rhi * fix gcc * Slangpy support with slang-rhi (shader-slang#219) * Get SlangPy compiling again * Add helper create_view function + make SRR read-write * Allow override of read_Calldata for tensors * Enable limitted submodule post processing * Fixes for PR * formatting * Metal cb retire (shader-slang#221) * Fixes for Metal texture tests * Point at merged PR * Fix typings for buffer with offset (shader-slang#222) * Fix error setting up app window ui * Fix image paths for texture array example * Add support for making 'buffer' compatible with buffer offset pair in typings * Enable typings * Fix formatting * Fix minor TODOs for slang-rhi merge (shader-slang#224) * Delete old command.cpp code * Delete old resourceview + add bindings/tests for SR layout * Update slang-rhi + fix refs to strideX/Y/Z * Hook up shader cache stats * DDS cubemaps can load (shader-slang#223) * Fix DDS cube map loading * Fix formatting * Read buffer direct (shader-slang#227) * update slang-rhi * read back buffer without extra copy * Fix doc (shader-slang#228) * fix pydoc generation * update pydoc.h * fix docstrings * update api order * update api.rst * remove obsolete api order entries * copy texture to/from buffer (shader-slang#225) * update slang-rhi * implement copy_texture_to_buffer / copy_buffer_to_texture * update texture tests --------- Co-authored-by: Simon Kallweit <[email protected]> * update slang-rhi * More metal tests (shader-slang#229) * fix test name * enable first half of shader cursor test * prepare print test for metal * fix naming * fix naming * fix naming * more naming gixes * run more tests on metal * update slang-rhi * update slang * remove remaining mentions of gfx * uint8_tX types not supported on metal --------- Co-authored-by: Simon Kallweit <[email protected]> * fix print test on vulkan * fix exclude * fix texture view format * Metal support (shader-slang#230) * default device to metal on macos * rename entry-point * rename entrypoint * rename entrypoint * fix typo * setup ui render pass correctly * default load ops to clear * formatting * update slang-rhi --------- Co-authored-by: Simon Kallweit <[email protected]> * CUDA support (shader-slang#231) * fix tests for cuda * adapt more tests for cuda * formatting * enable cuda testing * skip torch interop test on cuda device * update slang-rhi --------- Co-authored-by: Simon Kallweit <[email protected]> * Linux CUDA fixes (shader-slang#233) * skip tests failing due to slang not finding cuda_fp16.h * update slang-rhi --------- Co-authored-by: Simon Kallweit <[email protected]> * remove obsolete extension * copy optix headers to binary output dir * setup optix include path * enable optix tests * Linux fix optix (shader-slang#234) * remove obsolete extension * copy optix headers to binary output dir * setup optix include path * enable optix tests --------- Co-authored-by: Simon Kallweit <[email protected]> * skip more tests for now * skip more tests for now * Copy texture API (shader-slang#235) * update copy_texture api * remove dead code * disable vsync in pathtracer example (shader-slang#236) * Default to 1 mip level (shader-slang#237) * update slang-rhi * default to 1 mip level, use ALL_MIP_LEVELS to compute number of mips * Update docs (shader-slang#238) * update py_doc.h * enable doc strings * Upload buffer + texture support (shader-slang#240) * Initial versions of upload buffer/texture data * Tests for texture upload * Buffer tests * Helper apis for upload texture * Update subresource range and mip count (shader-slang#241) * update slang-rhi * updates due to slang-rhi API changes * use uint32_t for ScissorRect * update SubresourceRange * rename mip_count to mip_level_count * cleanup * rename "mip_level" to just "mip" * use ALL_LAYERS and ALL_MIPS constants * Cleanup before merge (shader-slang#246) * add changelog entry * remove dead code --------- Co-authored-by: Simon Kallweit <[email protected]> Co-authored-by: Chris Cummings <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expose
NDBuffer.to_numpyissue for dtypefloat3andfloat3[2]on metal and help test #206I'm also thinking about adding matrix dtype like
float2x2andfloat3x3to the test.All the other tests are passed currently on my machine as mentioned in #151 (comment). I'm not sure if #151 is resolved now.