fix(sidebar): prevent overflow in SidebarSeparator with horizontal orientation #8497
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@edouard-andrei is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
|
Looks like this PR modifies files in Consider applying the change to |
…ientation Updated SidebarSeparator component to use `data-[orientation=horizontal]:w-auto` instead of `w-auto` to prevent overflow issues caused by underlying Separator classes. The change makes the width override more specific, only applying to horizontal separators, which prevents conflicts with other Separator styling. This change is applied to apps/v4 (apps/www is deprecated).
|
Closing to create a fresh PR without the deprecated label since we've already removed the apps/www changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an overflow issue in the
SidebarSeparatorcomponent by making the width override more specific to horizontal orientations.Changes
Updated the
SidebarSeparatorcomponent in the v4 registry to usedata-[orientation=horizontal]:w-autoinstead ofw-auto. This prevents overflow issues caused by the underlyingSeparatorclasses.Files Changed
apps/v4/registry/new-york-v4/ui/sidebar.tsxWhy
The previous implementation used
w-autowhich applied to all separator orientations. This could cause overflow issues when theSeparatorcomponent's base classes conflicted with the sidebar styling. By usingdata-[orientation=horizontal]:w-auto, we ensure the override only applies when needed.Testing
pnpm build:registryNote
This change is applied only to
apps/v4asapps/wwwis deprecated.