fix(scroll-area): wrap viewport children in Content for base-ui#10539
Open
tautik wants to merge 1 commit intoshadcn-ui:mainfrom
Open
fix(scroll-area): wrap viewport children in Content for base-ui#10539tautik wants to merge 1 commit intoshadcn-ui:mainfrom
tautik wants to merge 1 commit intoshadcn-ui:mainfrom
Conversation
Contributor
|
@tautik is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
base-ui's ScrollArea.Content attaches a ResizeObserver that recalculates the thumb when content size changes. without it the thumb stays stale when content shrinks (e.g. a collapsed tree node) since the viewport's onScroll never fires for shrink-only updates. closes shadcn-ui#10534
tautik
force-pushed
the
fix/scroll-area-base-content
branch
from
f8b9c62 to
3deca39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wrap viewport children in
<ScrollAreaPrimitive.Content>for the base-ui scroll-area. base-ui'sContentattaches aResizeObserverthat recalculates the thumb when content dimensions change — without it the thumb stays stale when content shrinks (e.g. collapsing a tree node), since the viewport'sonScrollnever fires for shrink-only updates.ref: https://base-ui.com/react/components/scroll-area#content
radix-* variants are unaffected (different api).
closes #10534