Skip to content

fix(cli): use Phosphor SSR imports for RSC#10522

Open
cyphercodes wants to merge 1 commit intoshadcn-ui:mainfrom
cyphercodes:fix/phosphor-rsc-ssr-icons-push
Open

fix(cli): use Phosphor SSR imports for RSC#10522
cyphercodes wants to merge 1 commit intoshadcn-ui:mainfrom
cyphercodes:fix/phosphor-rsc-ssr-icons-push

Conversation

@cyphercodes
Copy link
Copy Markdown

Summary

  • Use Phosphor's SSR entrypoint when icon placeholders are transformed in React Server Component files.
  • Preserve the regular Phosphor client entrypoint for files with "use client".

Fixes #10503

Test plan

  • pnpm --filter=shadcn test -- src/utils/transformers/transform-icons.test.ts
  • pnpm --filter=shadcn typecheck
  • NODE_OPTIONS=--max-old-space-size=4096 pnpm --filter=shadcn build
  • pnpm --filter=shadcn format:check
  • pnpm exec prettier --check .changeset/calm-icons-serve.md packages/shadcn/src/icons/libraries.ts packages/shadcn/src/utils/transformers/transform-icons.ts packages/shadcn/src/utils/transformers/transform-icons.test.ts
  • git diff --check

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 27, 2026

@cyphercodes is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@cyphercodes cyphercodes force-pushed the fix/phosphor-rsc-ssr-icons-push branch from 9ccb93c to 9ac01c3 Compare April 27, 2026 15:23
@shadcn shadcn added the area: roadmap This looks great. We'll add it to the roadmap, review and merge. label Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: roadmap This looks great. We'll add it to the roadmap, review and merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug]: Phosphor icons and Breadcrumb component causes error

2 participants