-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up update_weights_from_tensor
#2695
Merged
merrymercy
merged 23 commits into
sgl-project:main
from
fzyzcjy:feat/improve_update_weights
Jan 2, 2025
Merged
Speed up update_weights_from_tensor
#2695
merrymercy
merged 23 commits into
sgl-project:main
from
fzyzcjy:feat/improve_update_weights
Jan 2, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzyzcjy
requested review from
merrymercy,
Ying1123,
zhyncs and
ispobock
as code owners
January 1, 2025 13:25
fzyzcjy
force-pushed
the
feat/improve_update_weights
branch
from
January 1, 2025 13:27
2752d62
to
80cd850
Compare
CI looks green now |
merrymercy
requested changes
Jan 2, 2025
This reverts commit fb3a8a8.
@fzyzcjy Yes, some these are flaky. |
I see |
YAMY1234
pushed a commit
to YAMY1234/sglang
that referenced
this pull request
Jan 2, 2025
XiaotongJiang
pushed a commit
to XiaotongJiang/sglang
that referenced
this pull request
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Speed up by avoiding tensor serialization and deserialization. Since it was only used for tests before and never released, the old one was OK, and the new one with API breaking changes seems OK.
Modifications
Checklist