Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support twoshot kernel #2688

Merged
merged 3 commits into from
Jan 5, 2025
Merged

Support twoshot kernel #2688

merged 3 commits into from
Jan 5, 2025

Conversation

yizhang2077
Copy link
Collaborator

@yizhang2077 yizhang2077 commented Dec 31, 2024

Motivation

support twoshot allreduce mainly from tensorrt llm, so custom allreduce can support larger data size, correctness has been verified, performance result in a100:

test_size = 512, world_size = 2, vllm time = 0.0130ms,custom time = 0.0119ms
test_size = 4096, world_size = 2, vllm time = 0.0113ms,custom time = 0.0136ms
test_size = 32768, world_size = 2, vllm time = 0.0121ms,custom time = 0.0122ms
test_size = 262144, world_size = 2, vllm time = 0.0176ms,custom time = 0.0170ms
test_size = 524288, world_size = 2, vllm time = 0.0223ms,custom time = 0.0228ms
test_size =1048576, world_size = 2, vllm time = 0.0325ms,custom time = 0.0326ms
test_size = 2097152, world_size = 2, vllm time = 0.0553ms,custom time = 0.0543ms

test_size = 512, world_size = 4, vllm time = 0.0135ms,custom time = 0.0119ms
test_size = 4096, world_size = 4, vllm time = 0.0121ms,custom time = 0.0140ms
test_size = 32768, world_size = 4, vllm time = 0.0135ms,custom time = 0.0137ms
test_size = 262144, world_size = 4, vllm time = 0.0239ms,custom time = 0.0206ms
test_size = 524288, world_size = 4, vllm time = 0.0313ms,custom time = 0.0306ms
test_size = 1048576, world_size = 4, vllm time = 0.0471ms,custom time = 0.0455ms

test_size = 512, world_size = 8, vllm time = 0.0140ms,custom time = 0.0137ms
test_size = 4096, world_size = 8, vllm time = 0.0142ms,custom time = 0.0165ms
test_size = 32768, world_size = 8, vllm time = 0.0186ms,custom time = 0.0189ms
test_size = 262144, world_size = 8, vllm time = 0.0300ms,custom time = 0.0287ms
test_size = 524288, world_size = 8, vllm time = 0.0354ms,custom time = 0.0348ms
test_size = 1048576, world_size = 8, vllm time = 0.0531ms,custom time = 0.0515ms

end to end performance will be analyzed in #2511

Modifications

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

@zhyncs zhyncs merged commit 3900a94 into main Jan 5, 2025
3 checks passed
@zhyncs zhyncs deleted the support-twoshot-kernel branch January 5, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants