-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cache Offload] Remove device sync overhead #2533
Open
Edenzzzz
wants to merge
15
commits into
sgl-project:xiezhq-hierarchical
Choose a base branch
from
Edenzzzz:offload_dev
base: xiezhq-hierarchical
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,294
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edenzzzz
requested review from
merrymercy,
Ying1123 and
hnyls2002
as code owners
December 20, 2024 17:23
Edenzzzz
changed the title
Replace device sync with event sync to reduce overhead
Replace device sync overhead
Dec 20, 2024
Edenzzzz
force-pushed
the
offload_dev
branch
from
December 20, 2024 22:05
602d287
to
abb02a5
Compare
Edenzzzz
changed the title
Replace device sync overhead
[Cache Offload] Replace device sync overhead
Dec 20, 2024
Edenzzzz
changed the title
[Cache Offload] Replace device sync overhead
[Cache Offload] Remove device sync overhead
Dec 22, 2024
Edenzzzz
force-pushed
the
offload_dev
branch
from
December 22, 2024 14:26
abb02a5
to
7c7a1f0
Compare
vanilla and selective write through
xiezhq-hermann
force-pushed
the
xiezhq-hierarchical
branch
from
December 27, 2024 00:55
4fd25f3
to
f20fc09
Compare
xiezhq-hermann
requested review from
zhyncs,
ispobock and
ByronHsu
as code owners
December 27, 2024 00:55
Edenzzzz
force-pushed
the
offload_dev
branch
from
December 28, 2024 08:29
7c7a1f0
to
cefd388
Compare
Edenzzzz
force-pushed
the
offload_dev
branch
from
December 28, 2024 08:34
cefd388
to
d2972a9
Compare
xiezhq-hermann
force-pushed
the
xiezhq-hierarchical
branch
3 times, most recently
from
January 2, 2025 08:06
2bd500a
to
1853cf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Device synchronization is expensive. In most cases we can use event or stream sync. https://developer.download.nvidia.com/compute/DevZone/docs/html/C/doc/html/group__CUDART__EVENT_g14c387cc57ce2e328f6669854e6020a5.html
Modifications
illegal memory access
issues. If you want to use another stream to write through in the background, we will also needpin_memory()
?cc @xiezhq-hermann , would appreciate if you could share a bug reproducer for that.
Checklist