Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill out functionality #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ncw
Copy link

@ncw ncw commented Sep 6, 2015

I've been using your library to add an Amazon Cloud Drive backend to rclone (see http://rclone.org )

I've managed to make the test suite pass with it. In the process I've added quite a few things to your library. I've tried not to break the external API in the process.

Here is the jumbo commit for you to look at. With a bit of effort I could break this up into smaller commits if you want.

* AccountService methods
  * GetEndpoints - gets the users endpoints.
    * Updates the endpoints in the client when called
    * The library doesn't work in Europe unless you call this first
* Node methods
  * Add more fields to Node struct
  * Trash
  * Add NodeFromId for clients who wish to manage their own IDs
* File methods
  * Open - returns an io.ReadCloser to download a file
  * Make GetNode, GetFolder, GetFile return ErrorNotFound if appropriate
  * Overwrite - ovewrites an existing file from an io.Reader
* Folder methods
  * CreateFolder
  * Put - uploads a file from an io.Reader
  * FolderFromId for clients who wish to manage their own IDs
* Fixes
  * Fix error reporting so that it does return the Amazon error in the body
  * Fix escaping of names in query with EscapeForFilter
* Internal
  * Changed Client.Do so that it can return an unclosed resp.Body

    * AccountService methods
      * GetEndpoints - gets the users endpoints.
        * Updates the endpoints in the client when called
        * The library doesn't work in Europe unless you call this first
    * Node methods
      * Add more fields to Node struct
      * Trash
      * Add NodeFromId for clients who wish to manage their own IDs
    * File methods
      * Open - returns an io.ReadCloser to download a file
      * Make GetNode, GetFolder, GetFile return ErrorNotFound if appropriate
      * Overwrite - ovewrites an existing file from an io.Reader
    * Folder methods
      * CreateFolder
      * Put - uploads a file from an io.Reader
      * FolderFromId for clients who wish to manage their own IDs
    * Fixes
      * Fix error reporting so that it does return the Amazon error in the body
      * Fix escaping of names in query with EscapeForFilter
    * Internal
      * Changed Client.Do so that it can return an unclosed resp.Body
@ncw
Copy link
Author

ncw commented Oct 12, 2015

@sgeb any thoughts on the above? I have the acd support completely working in rclone now, and I have a few more patches I could add if you are interested.

Thanks

Nick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant