Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecation warning on Windows #240

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mohd-akram
Copy link

spawn-command-with-kill uses an outdated version of spawn-command which causes a deprecation warning to be printed when running scripts due to the latter's use of util._extend.

What:

Why:

How:

Checklist:

  • Documentation N/A
  • Tests N/A
  • Ready to be merged
  • Added myself to contributors table

spawn-command-with-kill uses an outdated version of spawn-command which
causes a deprecation warning to be printed when running scripts due to
the latter's use of util._extend.
@mohd-akram
Copy link
Author

@sezna Did you get a chance to look at this? We run on many Windows machines and there's a glaring red warning every time a script is run, would be nice to have this fixed. I realize this package hasn't been updated in some years, but maybe this PR and #231 can be included in a patch release. I haven't encountered any other visible issues thus far.

Copy link
Owner

@sezna sezna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thank you!

@sezna
Copy link
Owner

sezna commented Feb 18, 2025

It looks like the actions are hanging. I'll take a look at that and then get this PR in.

@mohd-akram
Copy link
Author

@sezna Were you able to figure out the issue? I see the project is still using Travis CI, I'm not sure if that still works, but it might be easier to switch to GitHub Actions.

@mohd-akram
Copy link
Author

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants